Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solr listen on custom network interface #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ovidius-b
Copy link

@ovidius-b ovidius-b commented Mar 15, 2024

  • Added the possibility to define a network interface on which solr will listen using the variable solr_jetty_host.
  • Solr version 9.3.0 and higher introduced the -h host parameter in solr create script.
  • I kept backward compatibility for people already using this role, according to my tests.

@ovidius-b
Copy link
Author

Hi @geerlingguy anything else to be done from my side to make this PR happen?

Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Jul 26, 2024
@weeheavy
Copy link

According to https://ansible.jeffgeerling.com/ you still maintain this role so this PR could be merged.

- solr_jetty_host == '127.0.0.1'

# Create cores also when solr is listening on custom network interface. Just for solr 9.3.0 and higher.
- include_tasks: cores-post93.yml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the requirement for a separate cores task file here? I don't think that was explicitly explained but it includes a bit of duplicate code.

@github-actions github-actions bot removed the stale label Aug 2, 2024
Copy link

github-actions bot commented Dec 6, 2024

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants